Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2218333002:
Minor change in HostContentSettingsMapTest (Closed)
|
Created:
4 years, 4 months ago by lshang Modified:
4 years, 4 months ago Reviewers:
msramek CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMinor change in HostContentSettingsMapTest
This is to address a optional nit in https://codereview.chromium.org/2213313002/.
BUG=633680
Committed: https://crrev.com/dbcf5899da35bfedada435661e903a50ed1ffc56
Cr-Commit-Position: refs/heads/master@{#410558}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by lshang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Minor change in HostContentSettingsMapTest BUG= ========== to ========== Minor change in HostContentSettingsMapTest This is to address a optional nit in https://codereview.chromium.org/2213313002/. BUG=633680 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lshang@chromium.org changed reviewers: + msramek@chromium.org
PTAL thanks!
LGTM, thanks a lot for following up :)
The CQ bit was checked by lshang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lshang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Minor change in HostContentSettingsMapTest This is to address a optional nit in https://codereview.chromium.org/2213313002/. BUG=633680 ========== to ========== Minor change in HostContentSettingsMapTest This is to address a optional nit in https://codereview.chromium.org/2213313002/. BUG=633680 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Minor change in HostContentSettingsMapTest This is to address a optional nit in https://codereview.chromium.org/2213313002/. BUG=633680 ========== to ========== Minor change in HostContentSettingsMapTest This is to address a optional nit in https://codereview.chromium.org/2213313002/. BUG=633680 Committed: https://crrev.com/dbcf5899da35bfedada435661e903a50ed1ffc56 Cr-Commit-Position: refs/heads/master@{#410558} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dbcf5899da35bfedada435661e903a50ed1ffc56 Cr-Commit-Position: refs/heads/master@{#410558} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
