Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: chrome/browser/content_settings/host_content_settings_map_unittest.cc

Issue 2218333002: Minor change in HostContentSettingsMapTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/host_content_settings_map_unittest.cc
diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
index 2d501d075c71a33d427a425ed1630e83f56ac862..1d5965b221626e8c761acc741860cc25c812350b 100644
--- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc
+++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
@@ -1448,10 +1448,6 @@ TEST_F(HostContentSettingsMapTest, MigrateDomainScopedSettings) {
CONTENT_SETTING_ALLOW,
host_content_settings_map->GetContentSetting(
http_host, http_host, CONTENT_SETTINGS_TYPE_COOKIES, std::string()));
- EXPECT_EQ(CONTENT_SETTING_ALLOW,
- host_content_settings_map->GetContentSetting(
- http_host_narrower, http_host_narrower,
- CONTENT_SETTINGS_TYPE_COOKIES, std::string()));
host_content_settings_map->SetContentSettingCustomScope(
ContentSettingsPattern::FromURL(https_host),
ContentSettingsPattern::Wildcard(), CONTENT_SETTINGS_TYPE_COOKIES,
@@ -1463,6 +1459,10 @@ TEST_F(HostContentSettingsMapTest, MigrateDomainScopedSettings) {
// Settings also apply to subdomains.
EXPECT_EQ(CONTENT_SETTING_ALLOW,
host_content_settings_map->GetContentSetting(
+ http_host_narrower, http_host_narrower,
+ CONTENT_SETTINGS_TYPE_COOKIES, std::string()));
+ EXPECT_EQ(CONTENT_SETTING_ALLOW,
+ host_content_settings_map->GetContentSetting(
https_host_narrower, https_host_narrower,
CONTENT_SETTINGS_TYPE_COOKIES, std::string()));
@@ -1503,19 +1503,19 @@ TEST_F(HostContentSettingsMapTest, MigrateDomainScopedSettings) {
"https://example.com:443");
EXPECT_TRUE(settings[1].primary_pattern.ToString() == "*");
- // Cookie settings didn't get migrated.
EXPECT_EQ(
CONTENT_SETTING_ALLOW,
host_content_settings_map->GetContentSetting(
http_host, http_host, CONTENT_SETTINGS_TYPE_COOKIES, std::string()));
EXPECT_EQ(CONTENT_SETTING_ALLOW,
host_content_settings_map->GetContentSetting(
- http_host_narrower, http_host_narrower,
- CONTENT_SETTINGS_TYPE_COOKIES, std::string()));
- EXPECT_EQ(CONTENT_SETTING_ALLOW,
- host_content_settings_map->GetContentSetting(
https_host, https_host, CONTENT_SETTINGS_TYPE_COOKIES,
std::string()));
+ // Settings still apply to subdomains. Cookie settings didn't get migrated.
+ EXPECT_EQ(CONTENT_SETTING_ALLOW,
+ host_content_settings_map->GetContentSetting(
+ http_host_narrower, http_host_narrower,
+ CONTENT_SETTINGS_TYPE_COOKIES, std::string()));
EXPECT_EQ(CONTENT_SETTING_ALLOW,
host_content_settings_map->GetContentSetting(
https_host_narrower, https_host_narrower,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698