Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2218303002: Fix system info being dropped from system_logs.zip (Closed)

Created:
4 years, 4 months ago by afakhry
Modified:
4 years, 4 months ago
Reviewers:
rkc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix system info being dropped from system_logs.zip - Modify the thresholds so that less data end up in "Product Specific Data" of the report. - Do not exclude anything from the compressed system_logs.zip. BUG=634518 TEST=Filed reports should contain all sys info entires in their system_logs.zip Committed: https://crrev.com/aa732cc44d24f5edd84c4feebad94c1217a0ffa5 Cr-Commit-Position: refs/heads/master@{#410271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M components/feedback/feedback_common.cc View 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
afakhry
Rahul, as agreed, the follow up CL. Thanks!
4 years, 4 months ago (2016-08-06 00:50:00 UTC) #2
rkc
lgtm
4 years, 4 months ago (2016-08-06 06:57:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218303002/1
4 years, 4 months ago (2016-08-06 21:58:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-06 22:38:50 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 22:40:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa732cc44d24f5edd84c4feebad94c1217a0ffa5
Cr-Commit-Position: refs/heads/master@{#410271}

Powered by Google App Engine
This is Rietveld 408576698