Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: components/feedback/feedback_common.cc

Issue 2218303002: Fix system info being dropped from system_logs.zip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/feedback/feedback_common.cc
diff --git a/components/feedback/feedback_common.cc b/components/feedback/feedback_common.cc
index ef41a2777cf3c6adb8142a6a6c25f30643fee59b..fdb0c560084a041c1a043b0f7c158c28c80e3c7f 100644
--- a/components/feedback/feedback_common.cc
+++ b/components/feedback/feedback_common.cc
@@ -29,8 +29,8 @@ const char kMultilineEndString[] = "---------- END ----------\n\n";
// The below thresholds were chosen arbitrarily to conveniently show small data
// as part of the report itself without having to look into the system_logs.zip
// file.
-const size_t kFeedbackMaxLength = 4 * 1024;
-const size_t kFeedbackMaxLineCount = 40;
+const size_t kFeedbackMaxLength = 1024;
+const size_t kFeedbackMaxLineCount = 10;
const base::FilePath::CharType kLogsFilename[] =
FILE_PATH_LITERAL("system_logs.txt");
@@ -53,9 +53,7 @@ bool BelowCompressionThreshold(const std::string& content) {
}
// Converts the system logs into a string that we can compress and send
-// with the report. This method only converts those logs that we want in
-// the compressed zip file sent with the report, hence it ignores any logs
-// below the size threshold of what we want compressed.
+// with the report.
// TODO(dcheng): This should probably just take advantage of string's move
// constructor.
std::unique_ptr<std::string> LogsToString(
@@ -65,9 +63,6 @@ std::unique_ptr<std::string> LogsToString(
std::string key = iter.first;
std::string value = iter.second;
- if (BelowCompressionThreshold(value))
- continue;
-
base::TrimString(key, "\n ", &key);
base::TrimString(value, "\n ", &value);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698