Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2539)

Unified Diff: build/android/pylib/gtest/test_package.py

Issue 221823011: [Android] Change object types from AndroidCommands to DeviceUtils in build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | build/android/pylib/gtest/test_package_apk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/test_package.py
diff --git a/build/android/pylib/gtest/test_package.py b/build/android/pylib/gtest/test_package.py
index f82d029758accac420649ea1a4571284cf6eb55c..4281475db005ddbda4f6bbb3648ea494ed3d1f5b 100644
--- a/build/android/pylib/gtest/test_package.py
+++ b/build/android/pylib/gtest/test_package.py
@@ -16,51 +16,51 @@ class TestPackage(object):
def __init__(self, suite_name):
self.suite_name = suite_name
- def ClearApplicationState(self, adb):
+ def ClearApplicationState(self, device):
"""Clears the application state.
Args:
- adb: Instance of AndroidCommands.
+ device: Instance of DeviceUtils.
"""
raise NotImplementedError('Method must be overriden.')
- def CreateCommandLineFileOnDevice(self, adb, test_filter, test_arguments):
+ def CreateCommandLineFileOnDevice(self, device, test_filter, test_arguments):
"""Creates a test runner script and pushes to the device.
Args:
- adb: Instance of AndroidCommands.
+ device: Instance of DeviceUtils.
test_filter: A test_filter flag.
test_arguments: Additional arguments to pass to the test binary.
"""
raise NotImplementedError('Method must be overriden.')
- def GetAllTests(self, adb):
+ def GetAllTests(self, device):
"""Returns a list of all tests available in the test suite.
Args:
- adb: Instance of AndroidCommands.
+ device: Instance of DeviceUtils.
"""
raise NotImplementedError('Method must be overriden.')
- def GetGTestReturnCode(self, _adb):
+ def GetGTestReturnCode(self, _device):
return None
- def SpawnTestProcess(self, adb):
+ def SpawnTestProcess(self, device):
"""Spawn the test process.
Args:
- adb: Instance of AndroidCommands.
+ device: Instance of DeviceUtils.
Returns:
An instance of pexpect spawn class.
"""
raise NotImplementedError('Method must be overriden.')
- def Install(self, adb):
+ def Install(self, device):
"""Install the test package to the device.
Args:
- adb: Instance of AndroidCommands.
+ device: Instance of DeviceUtils.
"""
raise NotImplementedError('Method must be overriden.')
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | build/android/pylib/gtest/test_package_apk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698