Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2218163002: Revert of [Mac] Only enable the CFBundleBlocker in the browser process. (Closed)

Created:
4 years, 4 months ago by Robert Sesek
Modified:
4 years, 4 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] Only enable the CFBundleBlocker in the browser process. (patchset #1 id:1 of https://codereview.chromium.org/2199313002/ ) Reason for revert: Speculative revert for perf regression. BUG=https://crbug.com/634917 Original issue's description: > [Mac] Only enable the CFBundleBlocker in the browser process. > > In child processes, which are sandboxed in most cases, the sandbox will prevent > access to the filesystem locations where the potentially blocked bundles are > stored. Furthermore, on macOS 10.11 and higher, the Google Chrome build is > codesigned in such a way where bundle loading is blocked by SIP. > > This reduces some of the "triggered DYLD shared region unnest for map" messages. > > BUG=428858 > R=mark@chromium.org > > Committed: https://crrev.com/65e732d3b4dc595512b731143fd49d372acc1a87 > Cr-Commit-Position: refs/heads/master@{#409244} TBR=mark@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=428858 Committed: https://crrev.com/3026ec1f3bd67bb2cac5e42fe6d1a1298efcd049 Cr-Commit-Position: refs/heads/master@{#410113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Robert Sesek
Created Revert of [Mac] Only enable the CFBundleBlocker in the browser process.
4 years, 4 months ago (2016-08-05 17:30:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218163002/1
4 years, 4 months ago (2016-08-05 17:31:40 UTC) #3
Mark Mentovai
LGTMeh
4 years, 4 months ago (2016-08-05 17:34:25 UTC) #4
Mark Mentovai
Oh, nice, that wasn’t recognized as LGTM.
4 years, 4 months ago (2016-08-05 17:34:46 UTC) #5
Nico
On Fri, Aug 5, 2016 at 1:34 PM, <mark@chromium.org> wrote: > Oh, nice, that wasn’t ...
4 years, 4 months ago (2016-08-05 17:36:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:21:34 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:22:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3026ec1f3bd67bb2cac5e42fe6d1a1298efcd049
Cr-Commit-Position: refs/heads/master@{#410113}

Powered by Google App Engine
This is Rietveld 408576698