src/compiler.cc - Issue 2218083002: Remove bool result from analyze since it's always true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 2218083002: Remove bool result from analyze since it's always true (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: undo zone change Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index d9b55667bdc2abb78359886da080462b94f86c72..8306f45a69142145bf78ca5ccbed2da90c69fef5 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -1193,7 +1193,7 @@ Handle<SharedFunctionInfo> CompileToplevel(CompilationInfo* info) {

bool Compiler::Analyze(ParseInfo* info) {

DCHECK_NOT_NULL(info->literal());

if (!Rewriter::Rewrite(info)) return false;

- if (!Scope::Analyze(info)) return false;

+ Scope::Analyze(info);

if (!Renumber(info)) return false;

DCHECK_NOT_NULL(info->scope());

return true;