Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: src/ast/scopes.h

Issue 2218083002: Remove bool result from analyze since it's always true (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: undo zone change Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 07c880543c171305b6293329d0fd6121618790fd..a628a39d61ea10712153771f735b5cb05f66d59a 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -127,7 +127,7 @@ class Scope: public ZoneObject {
// Compute top scope and allocate variables. For lazy compilation the top
// scope only contains the single lazily compiled function, so this
// doesn't re-allocate variables repeatedly.
- static bool Analyze(ParseInfo* info);
+ static void Analyze(ParseInfo* info);
enum class DeserializationMode { kDeserializeOffHeap, kKeepScopeInfo };
@@ -596,11 +596,9 @@ class Scope: public ZoneObject {
Variable* LookupRecursive(VariableProxy* proxy, BindingKind* binding_kind,
AstNodeFactory* factory,
Scope* max_outer_scope = nullptr);
- MUST_USE_RESULT
- bool ResolveVariable(ParseInfo* info, VariableProxy* proxy,
+ void ResolveVariable(ParseInfo* info, VariableProxy* proxy,
AstNodeFactory* factory);
- MUST_USE_RESULT
- bool ResolveVariablesRecursively(ParseInfo* info, AstNodeFactory* factory);
+ void ResolveVariablesRecursively(ParseInfo* info, AstNodeFactory* factory);
// Tries to resolve local variables inside max_outer_scope; migrates those
// which cannot be resolved into migrate_to.
@@ -850,8 +848,7 @@ class DeclarationScope : public Scope {
// In the case of code compiled and run using 'eval', the context
// parameter is the context in which eval was called. In all other
// cases the context parameter is an empty handle.
- MUST_USE_RESULT
- bool AllocateVariables(ParseInfo* info, AstNodeFactory* factory);
+ void AllocateVariables(ParseInfo* info, AstNodeFactory* factory);
// To be called during parsing. Do just enough scope analysis that we can
// discard the Scope for lazily compiled functions. In particular, this
@@ -903,7 +900,6 @@ class DeclarationScope : public Scope {
Variable* this_function_;
// Module descriptor; module scopes only.
ModuleDescriptor* module_descriptor_;
- PendingCompilationErrorHandler pending_error_handler_;
};
} // namespace internal
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698