Remove bool result from analyze since it's always true

Remove bool result from analyze since it's always true

This also gets rid of the pending_error_handler field on DeclarationScope which wasn't actually used.

BUG=v8:5209
Committed: https://crrev.com/4943f722729c40d3702cf28505d5b80ecf38b9df
Cr-Commit-Position: refs/heads/master@{#38400}

[Toon Verwaest, 2016-08-05 14:38:09]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-08-05 14:38:10]

ptal

[adamk, 2016-08-05 17:51:10]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-08-05 17:51:11]

lgtm (looks like more vestigial strong mode stuff?)

https://codereview.chromium.org/2218083002/diff/20001/src/ast/scopes.h
File src/ast/scopes.h (right):

https://codereview.chromium.org/2218083002/diff/20001/src/ast/scopes.h#newcode11
src/ast/scopes.h:11: #include "src/pending-compilation-error-handler.h"
I think you can drop this include now.

[Toon Verwaest, 2016-08-05 18:27:54]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-05 18:27:55]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2218083002/#ps40001
(title: ""Remove include"")

[commit-bot: I haz the power, 2016-08-05 18:28:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:29:11]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/10396)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6448)

[Toon Verwaest, 2016-08-05 18:33:53]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-05 18:33:54]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2218083002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-05 18:33:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:57:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-05 19:00:03]

Description was changed from

==========
Remove bool result from analyze since it's always true

This also gets rid of the pending_error_handler field on DeclarationScope which
wasn't actually used.

BUG=v8:5209
==========

to

==========
Remove bool result from analyze since it's always true

This also gets rid of the pending_error_handler field on DeclarationScope which
wasn't actually used.

BUG=v8:5209

Committed: https://crrev.com/4943f722729c40d3702cf28505d5b80ecf38b9df
Cr-Commit-Position: refs/heads/master@{#38400}
==========

[commit-bot: I haz the power, 2016-08-05 19:00:04]

Patchset 4 (id:??) landed as
https://crrev.com/4943f722729c40d3702cf28505d5b80ecf38b9df
Cr-Commit-Position: refs/heads/master@{#38400}