test/cctest/compiler/test-loop-assignment-analysis.cc - Issue 2218083002: Remove bool result from analyze since it's always true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-loop-assignment-analysis.cc

Issue 2218083002: Remove bool result from analyze since it's always true (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/test-loop-assignment-analysis.cc

diff --git a/test/cctest/compiler/test-loop-assignment-analysis.cc b/test/cctest/compiler/test-loop-assignment-analysis.cc

index 3bf2909ccc9e323514d35be9b757bd06e7475448..1abdcb8eb7f9236f72e70c83af2e2cad5ef4588c 100644

--- a/test/cctest/compiler/test-loop-assignment-analysis.cc

+++ b/test/cctest/compiler/test-loop-assignment-analysis.cc

@@ -35,7 +35,7 @@ struct TestHelper : public HandleAndZoneScope {

CHECK(Parser::ParseStatic(&parse_info));

CHECK(Rewriter::Rewrite(&parse_info));

- CHECK(Scope::Analyze(&parse_info));

+ Scope::Analyze(&parse_info);

DeclarationScope* scope = info.literal()->scope();

AstValueFactory* factory = parse_info.ast_value_factory();

« no previous file with comments | « src/compiler.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »