Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2218053003: Add readme file explaining the code organization in //blimp/client. (Closed)

Created:
4 years, 4 months ago by nyquist
Modified:
4 years, 4 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add readme file explaining the code organization in //blimp/client. This CL explains how code should be organized within the //blimp/client directory. BUG=None Committed: https://crrev.com/8577969f1de38aa7d1337f19df2950ec606037c3 Cr-Commit-Position: refs/heads/master@{#410275}

Patch Set 1 #

Patch Set 2 : Added Java part and changed from 'code structure' to 'code organization' #

Patch Set 3 : Gitiles formatting of headers (removing code font for headers), and named anchor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -0 lines) Patch
A blimp/client/README.md View 1 2 1 chunk +175 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nyquist
dtrainor: PTAL Patch set 1 is what you saw offline, and patch set 2 is ...
4 years, 4 months ago (2016-08-06 00:03:52 UTC) #2
David Trainor- moved to gerrit
Hah sneaky! That's awesome! lgtm thanks for adding this!!! :)
4 years, 4 months ago (2016-08-06 04:39:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218053003/40001
4 years, 4 months ago (2016-08-07 01:07:44 UTC) #6
nyquist
fixed the gitiles formatting for headers. The code-formatting for headers removed the words (directory names) ...
4 years, 4 months ago (2016-08-07 01:08:41 UTC) #7
nyquist
Oh, and the last version is available at: https://chromium.googlesource.com/chromium/src.git/+/4fc76dcf5b9d80c11f7972fc18f3be794803790d/blimp/client/README.md
4 years, 4 months ago (2016-08-07 01:08:58 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-07 01:40:45 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-07 01:43:23 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8577969f1de38aa7d1337f19df2950ec606037c3
Cr-Commit-Position: refs/heads/master@{#410275}

Powered by Google App Engine
This is Rietveld 408576698