Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2218003006: [DevTools] Do not escape page titles (Closed)

Created:
4 years, 4 months ago by eostroukhov-old
Modified:
4 years, 4 months ago
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not escape page titles Page titles are used as strings, they should not be escaped. R=dgozman, pfeldman BUG=625502 Committed: https://crrev.com/ef93247015994a7da23e1021df735e048a20ad95 Cr-Commit-Position: refs/heads/master@{#410385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/devtools/devtools_targets_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
eostroukhov
4 years, 4 months ago (2016-08-05 23:03:39 UTC) #3
dgozman
lgtm
4 years, 4 months ago (2016-08-08 15:48:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218003006/1
4 years, 4 months ago (2016-08-08 15:51:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 17:03:03 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 17:04:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef93247015994a7da23e1021df735e048a20ad95
Cr-Commit-Position: refs/heads/master@{#410385}

Powered by Google App Engine
This is Rietveld 408576698