chrome/browser/devtools/devtools_targets_ui.cc - Issue 2218003006: [DevTools] Do not escape page titles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 2218003006: [DevTools] Do not escape page titles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_targets_ui.cc

diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc

index ec4ed3cd5ac2f7bd911d73779621f6b9e36004cb..f88eaa02c1c333fa19b62d1936ff9bf08bf985da 100644

--- a/chrome/browser/devtools/devtools_targets_ui.cc

+++ b/chrome/browser/devtools/devtools_targets_ui.cc

@@ -446,7 +446,7 @@ base::DictionaryValue* DevToolsTargetsUIHandler::Serialize(

target_data->SetString(kTargetTypeField, target.GetType());

target_data->SetBoolean(kAttachedField, target.IsAttached());

target_data->SetString(kUrlField, target.GetURL().spec());

- target_data->SetString(kNameField, net::EscapeForHTML(target.GetTitle()));

+ target_data->SetString(kNameField, target.GetTitle());

target_data->SetString(kFaviconUrlField, target.GetFaviconURL().spec());

target_data->SetString(kDescriptionField, target.GetDescription());

return target_data;

« no previous file with comments | « no previous file | no next file » | no next file with comments »