Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 2217753004: Move the call to ResourceDispatcherHostCreated from the ctor of the ResourceDispatcherHostImpl clas… (Closed)

Created:
4 years, 4 months ago by ananta
Modified:
4 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the call to ResourceDispatcherHostCreated from the ctor of the ResourceDispatcherHostImpl class to where the instance is actually created. This is part of the work to remove usage of ContentBrowserClient from the RDH class. BUG=598073 Committed: https://crrev.com/59c028d3e846d500415cf4d1e8d8167441198280 Cr-Commit-Position: refs/heads/master@{#410129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ananta
Please check if this approach is reasonable.
4 years, 4 months ago (2016-08-05 05:06:50 UTC) #5
jam
lgtm
4 years, 4 months ago (2016-08-05 15:55:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217753004/1
4 years, 4 months ago (2016-08-05 18:26:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 19:11:31 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:14:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59c028d3e846d500415cf4d1e8d8167441198280
Cr-Commit-Position: refs/heads/master@{#410129}

Powered by Google App Engine
This is Rietveld 408576698