Reset most ICs by returning to the canonical empty data arrays.

Reset most ICs by returning to the canonical empty data arrays.

We can't do this for the binary operators because they must be writable and not shared for the fast Smi op stubs to record invocation counts.

Suspected to help avoid races, see Issue #26946.

Also remove some dead code and avoid TLS.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/19716b351a8458b83a5260ca6606aa08942ed6aa

[rmacnak, 2016-08-04 21:52:25]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-08-04 23:02:14]

LGTM

[Cutch, 2016-08-04 23:11:34]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-08-04 23:11:35]

DBC: With this change can the code I added to find the first free slot in an
ICData be removed?

[rmacnak, 2016-08-05 00:00:55]

On 2016/08/04 23:11:35, Cutch wrote:
> DBC: With this change can the code I added to find the first free slot in an
> ICData be removed?

No, because it is still needed for the 2 arg ICs. Resetting them to a canonical
empty data array doesn't work because of the fast Smi op stubs, and allocating a
new data array doesn't work because some ICs are reset during a heap walk. I may
pull it out of the heap walk later as part of changes to fix pending static
calls.

[rmacnak, 2016-08-05 00:41:09]

Description was changed from

==========
Reset most ICs by returning to the canonical empty data arrays.

We can't do this for the binary operators because they must be writable and not
shared for the fast Smi op stubs to record invocation counts.

Suspected to help avoid races, see Issue #26946.

Also remove some dead code and avoid TLS.
==========

to

==========
Reset most ICs by returning to the canonical empty data arrays.

We can't do this for the binary operators because they must be writable and not
shared for the fast Smi op stubs to record invocation counts.

Suspected to help avoid races, see Issue #26946.

Also remove some dead code and avoid TLS.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/19716b351a8458b83a5260ca6606aa08942ed6aa
==========

[rmacnak, 2016-08-05 00:41:10]

Committed patchset #1 (id:1) manually as
19716b351a8458b83a5260ca6606aa08942ed6aa (presubmit successful).