Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: runtime/vm/object.h

Issue 2217733002: Reset most ICs by returning to the canonical empty data arrays. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index e9c928064597b4426a288910e3cb55bde397984b..6be932d22d556de1438fe9effe6492c2a118db16 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -1853,8 +1853,7 @@ class ICData : public Object {
bool IsImmutable() const;
- void Reset() const;
- void ResetData() const;
+ void Reset(Zone* zone) const;
// Note: only deopts with reasons before Unknown in this list are recorded in
// the ICData. All other reasons are used purely for informational messages
@@ -1960,7 +1959,6 @@ class ICData : public Object {
RawArray* FindFreeIndex(intptr_t* index) const;
void DebugDump() const;
- void ValidateSentinelLocations() const;
// Returns true if this is a two arg smi operation.
bool AddSmiSmiCheckForFastSmiStubs() const;
@@ -2133,7 +2131,7 @@ class ICData : public Object {
intptr_t TestEntryLength() const;
static RawArray* NewNonCachedEmptyICDataArray(intptr_t num_args_tested);
- static RawArray* NewEmptyICDataArray(intptr_t num_args_tested);
+ static RawArray* CachedEmptyICDataArray(intptr_t num_args_tested);
static RawICData* NewDescriptor(Zone* zone,
const Function& owner,
const String& target_name,
@@ -4504,7 +4502,7 @@ class Code : public Object {
// Used during reloading (see object_reload.cc). Calls Reset on all ICDatas
// that are embedded inside the Code object.
- void ResetICDatas() const;
+ void ResetICDatas(Zone* zone) const;
TokenPosition GetTokenPositionAt(intptr_t offset) const;
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698