Issue 2217693002: Delete NativeMessageHandler once a native port closes.

Issue 2217693002: Delete NativeMessageHandler once a native port closes. (Closed)

Created:
4 years, 4 months ago by turnidge

Modified:
4 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -3 lines)			Patch
M	runtime/vm/message_handler.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/message_handler.cc	View	1	11 chunks	+35 lines, -0 lines	0 comments	Download
M	runtime/vm/native_api_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/native_message_handler.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/port.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Cutch

LGTM Don't forget to add "Fixes https://github.com/dart-lang/sdk/issues/27002" to your CL description.

4 years, 4 months ago (2016-08-04 20:42:04 UTC) #3

turnidge

4 years, 4 months ago (2016-08-04 22:34:29 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f8ff7bd5c470449496268be2d5b8f767164ef3a7 (presubmit successful).