runtime/vm/port.cc - Issue 2217693002: Delete NativeMessageHandler once a native port closes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/port.cc

Issue 2217693002: Delete NativeMessageHandler once a native port closes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: edits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/port.cc

diff --git a/runtime/vm/port.cc b/runtime/vm/port.cc

index 2541b38079e10746ef0eadfddee18fb6a2380716..d5513d598ac2c984a3751775d3dbd0fced91f909 100644

--- a/runtime/vm/port.cc

+++ b/runtime/vm/port.cc

@@ -216,7 +216,8 @@ bool PortMap::ClosePort(Dart_Port port) {

}

handler->ClosePort(port);

if (!handler->HasLivePorts() && handler->OwnedByPortMap()) {

- delete handler;

+ // Delete handler as soon as it isn't busy with a task.

+ handler->RequestDeletion();

}

return true;

}

« no previous file with comments | « runtime/vm/native_message_handler.cc ('k') | no next file » | no next file with comments »