Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2217463003: Color profile layout test cleanup (Closed)

Created:
4 years, 4 months ago by ccameron
Modified:
4 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, shans, rjwright, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, jam, dcheng, feature-media-reviews_chromium.org, darin-cc_chromium.org, eric.carlson_apple.com, darktears, blink-reviews, jochen+watch_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Color profile layout test cleanup Remove callers to setImageColorProfilesEnabled, since it no longer has an effect. Rename the "whacked" color profile to the more descriptive "colorSpin" color profile. BUG=44872 Committed: https://crrev.com/dde2b8cb74bec2c53017c0445e0696a458c81d78 Cr-Commit-Position: refs/heads/master@{#409999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -173 lines) Patch
M content/test/layouttest_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-animate.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-animate-rotate.html View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-background-clip-text.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-background-image-cover.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-background-image-cross-fade.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-background-image-cross-fade-png.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-background-image-repeat.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-background-image-space.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-border-fade.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-border-image.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-border-image-source.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-border-radius.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-clip.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-drag-image.html View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-filter.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-group.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-iframe.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-canvas.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-canvas-pattern.html View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-canvas-svg.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-filter-all.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-object-fit.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-profile-match.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-pseudo-content.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-shape.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-image-svg-resource-url.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-layer.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-layer-filter.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-mask-image-svg.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-adobe-to-srgb.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-object.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-reflection.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-svg.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-svg-fill-text.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-svg-foreign-object.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-munsell-bt601-smpte-to-srgb.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-munsell-bt709-to-srgb.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video-poster-image.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video-seek.html View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter.html View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video-seek-object-fit.html View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
ccameron
This does some search-replace cleanup on layout tests. junov@ for WebKit/ avi@ for content/ stamp ...
4 years, 4 months ago (2016-08-04 22:52:34 UTC) #4
Justin Novosad
On 2016/08/04 22:52:34, ccameron wrote: > This does some search-replace cleanup on layout tests. > ...
4 years, 4 months ago (2016-08-05 00:08:27 UTC) #7
Avi (use Gerrit)
lgtm content stamp
4 years, 4 months ago (2016-08-05 03:05:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217463003/1
4 years, 4 months ago (2016-08-05 05:49:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 05:53:56 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 05:55:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dde2b8cb74bec2c53017c0445e0696a458c81d78
Cr-Commit-Position: refs/heads/master@{#409999}

Powered by Google App Engine
This is Rietveld 408576698