Color: Add ColorCorrectRendering flag

Color: Add ColorCorrectRendering flag

Re-use the ImageColorProfiles flag (except in the interface to testing
internals).

Hook this up to:
- Remove QCMS color profiles from being baked into decoded images.
- Tag decoded image SkBitmaps with their specified color profile.
- Set canvas elements to be sRGB.

Add support for enabling this feature in layout tests. Images with
color profiles often appear blank with this flag, so don't add layout
tests yet.

BUG=44872
Committed: https://crrev.com/7c4df6c240fd6bbc5fbf622d503f470cd505c643
Cr-Commit-Position: refs/heads/master@{#411241}

[ccameron, 2016-08-04 22:51:20]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 22:51:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 22:55:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 22:55:58]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-08-04 22:57:02]

Description was changed from

==========
Color: Add ColorCorrectRendering flag

Hook this up to:
- Remove QCMS color profiles from being baked into decoded images.
- Tag decoded image SkBitmaps with their specified color profile.
- Set canvas elements to be sRGB.

Add support for enabling this feature in layout tests. Images with
color profiles often appear blank with this flag, so don't add layout
tests yet.

BUG=44872
==========

to

==========
Color: Add ColorCorrectRendering flag

Re-use the ImageColorProfiles flag (except in the interface to testing
internals).

Hook this up to:
- Remove QCMS color profiles from being baked into decoded images.
- Tag decoded image SkBitmaps with their specified color profile.
- Set canvas elements to be sRGB.

Add support for enabling this feature in layout tests. Images with
color profiles often appear blank with this flag, so don't add layout
tests yet.

BUG=44872
==========

[ccameron, 2016-08-04 22:57:02]

ccameron@chromium.org changed reviewers:
+ junov@chromium.org

[ccameron, 2016-08-04 22:57:52]

ptal

(it's complaining about applying the patch in the tryjobs cause I haven't set up
the dependency chain clearly enough for it -- builds and runs and works locally)

[Justin Novosad, 2016-08-05 00:17:06]

https://codereview.chromium.org/2216073002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
(right):

https://codereview.chromium.org/2216073002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:67:
colorSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named);
Actually, could you leave this part out? I have a WIP CL that will do this part
very differently.

[ccameron, 2016-08-05 00:39:49]

https://codereview.chromium.org/2216073002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
(right):

https://codereview.chromium.org/2216073002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:67:
colorSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named);
On 2016/08/05 00:17:06, junov (slow until August 8) wrote:
> Actually, could you leave this part out? I have a WIP CL that will do this
part
> very differently.

Sg -- removed.

[Justin Novosad, 2016-08-05 01:02:23]

lgtm

[ccameron, 2016-08-05 06:09:19]

ccameron@chromium.org changed reviewers:
+ oshima@chromium.org

[ccameron, 2016-08-05 06:09:19]

OWNER stamps:
oshima: chrome/browser/chromeos/
avi: content/

[Stephen Chennney, 2016-08-05 13:24:26]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2016-08-05 13:24:27]

Would you mind briefly explaining why this is something that users might want to
change in settings, rather than a RuntimeEnabledFeature controlled from the
command line that we test for a while then turn permanently on?

[oshima, 2016-08-05 14:21:12]

c/b/chromeos lgtm

[Justin Novosad, 2016-08-05 21:29:25]

On 2016/08/05 13:24:27, Stephen Chennney wrote:
> Would you mind briefly explaining why this is something that users might want
to
> change in settings, rather than a RuntimeEnabledFeature controlled from the
> command line that we test for a while then turn permanently on?

The new flag *is* in RuntimeEnabledFeatures
The thing that was in InternalSettings is being removed.

[ccameron, 2016-08-08 22:42:02]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2016-08-08 22:42:03]

Adding avi@ for content/ stamp

[Avi (use Gerrit), 2016-08-09 00:15:46]

lgtm

content stamp

[dcheng, 2016-08-09 01:34:30]

https://codereview.chromium.org/2216073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/Page.cpp (right):

https://codereview.chromium.org/2216073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/Page.cpp:296: void
Page::resetDeviceColorProfileForTesting()
Drive-by: do we still need this method if it's just an empty stub?

[ccameron, 2016-08-09 01:45:04]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 01:45:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 01:53:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:53:13]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[ccameron, 2016-08-09 02:05:48]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 02:06:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-08-09 02:59:21]

https://codereview.chromium.org/2216073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/Page.cpp (right):

https://codereview.chromium.org/2216073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/Page.cpp:296: void
Page::resetDeviceColorProfileForTesting()
On 2016/08/09 01:34:30, dcheng (OOO Aug 1 - Aug 11) wrote:
> Drive-by: do we still need this method if it's just an empty stub?

Nope. And, we can tear out a fairly long tail from there, which I've pulled into
this.

[ccameron, 2016-08-09 02:59:56]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2016-08-09 02:59:57]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-08-09 02:59:57]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
avi@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2216073002/#ps40001
(title: "Delete bunches more stuff")

[commit-bot: I haz the power, 2016-08-09 03:00:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 03:06:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 03:06:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ccameron, 2016-08-09 06:17:22]

ccameron@chromium.org changed reviewers:
+ pdr@chromium.org

[ccameron, 2016-08-09 06:17:23]

Adding pdr@ to OWNER WebKit public/web parts

[pdr., 2016-08-09 23:23:04]

On 2016/08/09 at 06:17:23, ccameron wrote:
> Adding pdr@ to OWNER WebKit public/web parts

LGTM

[ccameron, 2016-08-09 23:25:01]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-08-09 23:25:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 23:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 23:35:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ccameron, 2016-08-10 00:28:27]

ccameron@chromium.org changed reviewers:
+ inferno@chromium.org

[ccameron, 2016-08-10 00:28:28]

Adding inferno for traits_macros OWNER

[aarya, 2016-08-10 04:48:01]

aarya@google.com changed reviewers:
+ aarya@google.com, tsepez@chromium.org
- inferno@chromium.org

[Tom Sepez, 2016-08-10 17:29:32]

traits LGTM.

[ccameron, 2016-08-10 17:53:37]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:54:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 17:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:57:48]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-08-10 19:32:38]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-08-10 19:32:39]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
oshima@chromium.org, junov@chromium.org, tsepez@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2216073002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-10 19:33:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 21:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:37:57]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ccameron, 2016-08-11 00:40:06]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-08-11 00:41:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 03:03:41]

Description was changed from

==========
Color: Add ColorCorrectRendering flag

Re-use the ImageColorProfiles flag (except in the interface to testing
internals).

Hook this up to:
- Remove QCMS color profiles from being baked into decoded images.
- Tag decoded image SkBitmaps with their specified color profile.
- Set canvas elements to be sRGB.

Add support for enabling this feature in layout tests. Images with
color profiles often appear blank with this flag, so don't add layout
tests yet.

BUG=44872
==========

to

==========
Color: Add ColorCorrectRendering flag

Re-use the ImageColorProfiles flag (except in the interface to testing
internals).

Hook this up to:
- Remove QCMS color profiles from being baked into decoded images.
- Tag decoded image SkBitmaps with their specified color profile.
- Set canvas elements to be sRGB.

Add support for enabling this feature in layout tests. Images with
color profiles often appear blank with this flag, so don't add layout
tests yet.

BUG=44872
==========

[commit-bot: I haz the power, 2016-08-11 03:03:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-11 03:05:37]

Description was changed from

==========
Color: Add ColorCorrectRendering flag

Re-use the ImageColorProfiles flag (except in the interface to testing
internals).

Hook this up to:
- Remove QCMS color profiles from being baked into decoded images.
- Tag decoded image SkBitmaps with their specified color profile.
- Set canvas elements to be sRGB.

Add support for enabling this feature in layout tests. Images with
color profiles often appear blank with this flag, so don't add layout
tests yet.

BUG=44872
==========

to

==========
Color: Add ColorCorrectRendering flag

Re-use the ImageColorProfiles flag (except in the interface to testing
internals).

Hook this up to:
- Remove QCMS color profiles from being baked into decoded images.
- Tag decoded image SkBitmaps with their specified color profile.
- Set canvas elements to be sRGB.

Add support for enabling this feature in layout tests. Images with
color profiles often appear blank with this flag, so don't add layout
tests yet.

BUG=44872

Committed: https://crrev.com/7c4df6c240fd6bbc5fbf622d503f470cd505c643
Cr-Commit-Position: refs/heads/master@{#411241}
==========

[commit-bot: I haz the power, 2016-08-11 03:05:39]

Patchset 4 (id:??) landed as
https://crrev.com/7c4df6c240fd6bbc5fbf622d503f470cd505c643
Cr-Commit-Position: refs/heads/master@{#411241}