Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 22174002: Do not rely on the exit code of browser to determine if the *command* was successful (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 3d575922dec5b0c85539f0a0c9984de4685bf07e..fc3948332fb4667798ecc5b4941d08c220e26f3d 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -726,7 +726,13 @@ class BrowserCommandOutputImpl extends CommandOutputImpl {
}
}
- bool didFail(TestCase testCase) {
+ bool get canRunDependendCommands {
+ // We cannot rely on the exit code of content_shell as a method to determine
+ // if we were successful or not.
+ return super.canRunDependendCommands && !didFail(null);
kustermann 2013/08/05 10:23:44 If this returns 'false' and command.numRetries > 0
+ }
+
+ bool didFail(TestCase _) {
if (_failedBecauseOfMissingXDisplay) {
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698