Do not rely on the exit code of browser to determine if the *command* was successful

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 708 matching lines @@
           time,
           compilationSkipped) {
     _failedBecauseOfMissingXDisplay = _didFailBecauseOfMissingXDisplay();
     if (_failedBecauseOfMissingXDisplay) {
       DebugLogger.warning("Warning: Test failure because of missing XDisplay");
       // If we get the X server error, or DRT crashes with a core dump, retry
       // the test.
     }
   }
 
-  bool didFail(TestCase testCase) {
+  bool get canRunDependendCommands {
+    // We cannot rely on the exit code of content_shell as a method to determine
+    // if we were successful or not.
+    return super.canRunDependendCommands && !didFail(null);

[kustermann, 2013/08/05 10:23:44]

If this returns 'false' and command.numRetries > 0, we'll retry it.

+  }
+
+  bool didFail(TestCase _) {
     if (_failedBecauseOfMissingXDisplay) {
       return true;
     }
 
     if (command.expectedOutputFile != null) {
       // We are either doing a pixel test or a layout test with content shell
       return _failedBecauseOfUnexpectedDRTOutput;
     }
     return _browserTestFailure;
   }
@@ skipping 1317 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
     _allDone();
   }
 }