content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from aboxhall Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_auralinux.cc ('k') | content/browser/accessibility/browser_accessibility_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index 1b841569615e845be4cf624c2bf50d4f2b7e4ef7..900686dcea03ba6b1791b4ad7ce9006b0a793139 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -1172,7 +1172,7 @@ bool InitializeAccessibilityTreeSearch(

- (NSPoint)origin {

if (![self instanceActive])

return NSMakePoint(0, 0);

- gfx::Rect bounds = browserAccessibility_->GetLocalBoundsRect();

+ gfx::Rect bounds = browserAccessibility_->GetPageBoundsRect();

return NSMakePoint(bounds.x(), bounds.y());

}

@@ -1610,7 +1610,7 @@ bool InitializeAccessibilityTreeSearch(

- (NSValue*)size {

if (![self instanceActive])

return nil;

- gfx::Rect bounds = browserAccessibility_->GetLocalBoundsRect();

+ gfx::Rect bounds = browserAccessibility_->GetPageBoundsRect();

return [NSValue valueWithSize:NSMakeSize(bounds.width(), bounds.height())];

}

@@ -2248,7 +2248,7 @@ bool InitializeAccessibilityTreeSearch(

if ([self internalRole] != ui::AX_ROLE_STATIC_TEXT)

return nil;

NSRange range = [(NSValue*)parameter rangeValue];

- gfx::Rect rect = browserAccessibility_->GetGlobalBoundsForRange(

+ gfx::Rect rect = browserAccessibility_->GetScreenBoundsForRange(

range.location, range.length);

NSPoint origin = NSMakePoint(rect.x(), rect.y());

NSSize size = NSMakeSize(rect.width(), rect.height());

@@ -2312,7 +2312,7 @@ bool InitializeAccessibilityTreeSearch(

DCHECK_GE(startOffset, 0);

DCHECK_GE(endOffset, 0);

- gfx::Rect rect = BrowserAccessibilityManager::GetLocalBoundsForRange(

+ gfx::Rect rect = BrowserAccessibilityManager::GetPageBoundsForRange(

*startObject, startOffset, *endObject, endOffset);

NSPoint origin = NSMakePoint(rect.x(), rect.y());

NSSize size = NSMakeSize(rect.width(), rect.height());