content/browser/accessibility/browser_accessibility_auralinux.cc - Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_auralinux.cc

Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from aboxhall Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_auralinux.cc

diff --git a/content/browser/accessibility/browser_accessibility_auralinux.cc b/content/browser/accessibility/browser_accessibility_auralinux.cc

index 38066a198e55d451db55b3c27b55e1e370b37bc9..b3e8ae269e6e251d641b4094a1362059bcfab4d0 100644

--- a/content/browser/accessibility/browser_accessibility_auralinux.cc

+++ b/content/browser/accessibility/browser_accessibility_auralinux.cc

@@ -144,7 +144,7 @@ static AtkObject* browser_accessibility_accessible_at_point(

return NULL;

gfx::Point point(x, y);

- if (!obj->GetGlobalBoundsRect().Contains(point))

+ if (!obj->GetScreenBoundsRect().Contains(point))

return NULL;

BrowserAccessibility* result = obj->BrowserAccessibilityForPoint(point);

@@ -170,7 +170,7 @@ static void browser_accessibility_get_extents(AtkComponent* atk_component,

if (!obj)

return;

- gfx::Rect bounds = obj->GetGlobalBoundsRect();

+ gfx::Rect bounds = obj->GetScreenBoundsRect();

if (x)

*x = bounds.x();

if (y)

@@ -300,7 +300,7 @@ void GetImagePositionSize(BrowserAccessibilityAuraLinux* obj,

gint* y,

gint* width,

gint* height) {

- gfx::Rect img_pos_size = obj->GetGlobalBoundsRect();

+ gfx::Rect img_pos_size = obj->GetScreenBoundsRect();

if (x)

*x = img_pos_size.x();