chrome/browser/ui/views/tabs/tab_renderer_data.h - Issue 2217273002: Desaturate the favicon shown in the tab when a network error is encountered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_renderer_data.h

Issue 2217273002: Desaturate the favicon shown in the tab when a network error is encountered (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tabs/tab_renderer_data.h

diff --git a/chrome/browser/ui/views/tabs/tab_renderer_data.h b/chrome/browser/ui/views/tabs/tab_renderer_data.h

index 829de7e559b9b2f8e44154e3c215ed6884297f0e..e8c7adaca39e5b8c447aa563218f2e6fb69bd2d0 100644

--- a/chrome/browser/ui/views/tabs/tab_renderer_data.h

+++ b/chrome/browser/ui/views/tabs/tab_renderer_data.h

@@ -45,6 +45,7 @@ struct CHROME_VIEWS_EXPORT TabRendererData {

bool pinned;

bool blocked;

bool app;

+ bool network_error;

sky 2016/08/11 20:46:21 Can this be merged into the NetworkState enum abov

edwardjung 2016/08/12 14:42:55 Done. Although not sure it's as clean as we now ha

TabAlertState alert_state;

};

« chrome/browser/ui/views/tabs/tab.cc ('K') | « chrome/browser/ui/views/tabs/tab.cc ('k') | chrome/browser/ui/views/tabs/tab_renderer_data.cc » ('j') | no next file with comments »