chrome/browser/ui/views/tabs/tab_renderer_data.h - Issue 2217273002: Desaturate the favicon shown in the tab when a network error is encountered

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/tabs/tab_renderer_data.h

Issue 2217273002: Desaturate the favicon shown in the tab when a network error is encountered (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_RENDERER_DATA_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_RENDERER_DATA_H_

6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_RENDERER_DATA_H_	6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_RENDERER_DATA_H_

7	7

8 #include "base/strings/string16.h"	8 #include "base/strings/string16.h"

9 #include "chrome/browser/ui/tabs/tab_utils.h"	9 #include "chrome/browser/ui/tabs/tab_utils.h"

10 #include "chrome/browser/ui/views/chrome_views_export.h"	10 #include "chrome/browser/ui/views/chrome_views_export.h"

(...skipping 27 matching lines...) Expand all Loading...
38 NetworkState network_state;	38 NetworkState network_state;

39 base::string16 title;	39 base::string16 title;

40 GURL url;	40 GURL url;

41 bool loading;	41 bool loading;

42 base::TerminationStatus crashed_status;	42 base::TerminationStatus crashed_status;

43 bool incognito;	43 bool incognito;

44 bool show_icon;	44 bool show_icon;

45 bool pinned;	45 bool pinned;

46 bool blocked;	46 bool blocked;

47 bool app;	47 bool app;

	48 bool network_error;
	sky 2016/08/11 20:46:21 Can this be merged into the NetworkState enum abov Can this be merged into the NetworkState enum above? edwardjung 2016/08/12 14:42:55 Done. Although not sure it's as clean as we now ha Show quoted text On 2016/08/11 20:46:21, sky wrote: > Can this be merged into the NetworkState enum above? Done. Although not sure it's as clean as we now have to check against two states in tab.cc
48 TabAlertState alert_state;	49 TabAlertState alert_state;

49 };	50 };

50	51

51 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_RENDERER_DATA_H_	52 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_RENDERER_DATA_H_

OLD	NEW

« chrome/browser/ui/views/tabs/tab.cc ('K') | « chrome/browser/ui/views/tabs/tab.cc ('k') | chrome/browser/ui/views/tabs/tab_renderer_data.cc » ('j') | no next file with comments »