Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: components/feedback/feedback_data.h

Issue 2217163003: Clean up and modernize the feedback code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actual Fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feedback/feedback_data.h
diff --git a/components/feedback/feedback_data.h b/components/feedback/feedback_data.h
index ad7a76da2a00a67040c0774e89cdd39a511f9957..a56bfcd4594b3ef6dcf5367fd889ac15e0479a32 100644
--- a/components/feedback/feedback_data.h
+++ b/components/feedback/feedback_data.h
@@ -42,12 +42,6 @@ class FeedbackData : public FeedbackCommon {
void AttachAndCompressFileData(
std::unique_ptr<std::string> attached_filedata);
- // Called once we have compressed our system logs.
- void OnCompressLogsComplete(std::unique_ptr<std::string> compressed_logs);
-
- // Called once we have compressed our attached file.
- void OnCompressFileComplete(std::unique_ptr<std::string> compressed_file);
afakhry 2016/08/05 22:50:53 These two functions were not implemented any where
-
// Returns true if we've completed all the tasks needed before we can send
// feedback - at this time this is includes getting the feedback page data
// and compressing the system logs.

Powered by Google App Engine
This is Rietveld 408576698