Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: components/feedback/feedback_data.h

Issue 2217163003: Clean up and modernize the feedback code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actual Fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FEEDBACK_FEEDBACK_DATA_H_ 5 #ifndef COMPONENTS_FEEDBACK_FEEDBACK_DATA_H_
6 #define COMPONENTS_FEEDBACK_FEEDBACK_DATA_H_ 6 #define COMPONENTS_FEEDBACK_FEEDBACK_DATA_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 24 matching lines...) Expand all
35 void SetAndCompressSystemInfo(std::unique_ptr<SystemLogsMap> sys_info); 35 void SetAndCompressSystemInfo(std::unique_ptr<SystemLogsMap> sys_info);
36 36
37 // Sets the histograms for this instance and kicks off its 37 // Sets the histograms for this instance and kicks off its
38 // compression. 38 // compression.
39 void SetAndCompressHistograms(std::unique_ptr<std::string> histograms); 39 void SetAndCompressHistograms(std::unique_ptr<std::string> histograms);
40 40
41 // Sets the attached file data and kicks off its compression. 41 // Sets the attached file data and kicks off its compression.
42 void AttachAndCompressFileData( 42 void AttachAndCompressFileData(
43 std::unique_ptr<std::string> attached_filedata); 43 std::unique_ptr<std::string> attached_filedata);
44 44
45 // Called once we have compressed our system logs.
46 void OnCompressLogsComplete(std::unique_ptr<std::string> compressed_logs);
47
48 // Called once we have compressed our attached file.
49 void OnCompressFileComplete(std::unique_ptr<std::string> compressed_file);
afakhry 2016/08/05 22:50:53 These two functions were not implemented any where
50
51 // Returns true if we've completed all the tasks needed before we can send 45 // Returns true if we've completed all the tasks needed before we can send
52 // feedback - at this time this is includes getting the feedback page data 46 // feedback - at this time this is includes getting the feedback page data
53 // and compressing the system logs. 47 // and compressing the system logs.
54 bool IsDataComplete(); 48 bool IsDataComplete();
55 49
56 // Sends the feedback report if we have all our data complete. 50 // Sends the feedback report if we have all our data complete.
57 void SendReport(); 51 void SendReport();
58 52
59 // Getters 53 // Getters
60 content::BrowserContext* context() const { return context_; } 54 content::BrowserContext* context() const { return context_; }
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 93
100 int pending_op_count_; 94 int pending_op_count_;
101 bool report_sent_; 95 bool report_sent_;
102 96
103 DISALLOW_COPY_AND_ASSIGN(FeedbackData); 97 DISALLOW_COPY_AND_ASSIGN(FeedbackData);
104 }; 98 };
105 99
106 } // namespace feedback 100 } // namespace feedback
107 101
108 #endif // COMPONENTS_FEEDBACK_FEEDBACK_DATA_H_ 102 #endif // COMPONENTS_FEEDBACK_FEEDBACK_DATA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698