Clean up and modernize the feedback code

Clean up and modernize the feedback code

BUG=634518
TEST=Tests should keep passing.

Committed: https://crrev.com/7945509958001242f8d26cf3b6d3d4e5596f52c8
Cr-Commit-Position: refs/heads/master@{#410223}

[afakhry, 2016-08-05 18:56:36]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 18:57:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 19:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 19:46:09]

Dry run: This issue passed the CQ dry run.

[afakhry, 2016-08-05 22:38:57]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 22:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-08-05 22:39:44]

Description was changed from

==========
Fix some data are dropped from the sys_info file in feedback reports

- Clean up and modernize.
- Fix skipping data below compression threshold issue.

BUG=634518
TEST=
==========

to

==========
Fix some data are dropped from the sys_info file in feedback reports

- Clean up and modernize.
- Fix skipping data below compression threshold issue.

BUG=634518
TEST=Tests should keep passing. system_logs.zip on feedback reports should
contain everything.
==========

[afakhry, 2016-08-05 22:50:52]

afakhry@chromium.org changed reviewers:
+ rkc@chromium.org

[afakhry, 2016-08-05 22:50:53]

Rahul, please take a look, thank you!

https://codereview.chromium.org/2217163003/diff/20001/components/feedback/fee...
File components/feedback/feedback_common.h (left):

https://codereview.chromium.org/2217163003/diff/20001/components/feedback/fee...
components/feedback/feedback_common.h:48: static bool
BelowCompressionThreshold(const std::string& content);
Moved to anonymous namespace.

https://codereview.chromium.org/2217163003/diff/20001/components/feedback/fee...
components/feedback/feedback_common.h:52: void CompressFile(const
base::FilePath& filename,
Moved to protected.

https://codereview.chromium.org/2217163003/diff/20001/components/feedback/fee...
components/feedback/feedback_common.h:59: void CompressLogs();
Moved to protected.

https://codereview.chromium.org/2217163003/diff/20001/components/feedback/fee...
components/feedback/feedback_common.h:62: userfeedback::ExtensionSubmit*
feedback_data) const;
Moved to private.

https://codereview.chromium.org/2217163003/diff/20001/components/feedback/fee...
File components/feedback/feedback_data.h (left):

https://codereview.chromium.org/2217163003/diff/20001/components/feedback/fee...
components/feedback/feedback_data.h:49: void
OnCompressFileComplete(std::unique_ptr<std::string> compressed_file);
These two functions were not implemented any where! :D

[rkc, 2016-08-05 23:00:57]

This CL is great! Could we separate out the fix in a separate CL though?

Usually mixing CLs at a later stage can cause people to get confused, when they
see unrelated changes in the same commit. It is hard to discern which parts were
actually part of the fix and which were just cleanup.

[afakhry, 2016-08-05 23:23:58]

Description was changed from

==========
Fix some data are dropped from the sys_info file in feedback reports

- Clean up and modernize.
- Fix skipping data below compression threshold issue.

BUG=634518
TEST=Tests should keep passing. system_logs.zip on feedback reports should
contain everything.
==========

to

==========
Clean up and modernize the feedback code

BUG=634518
TEST=Tests should keep passing.
==========

[afakhry, 2016-08-05 23:24:11]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:24:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-08-05 23:25:50]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-08-05 23:26:49]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[afakhry, 2016-08-05 23:29:00]

I completely agree with you! Let's keep this as a clean-up only CL. I will
follow up with a CL that has the actual fix after this land.
Thanks!

[afakhry, 2016-08-05 23:29:17]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rkc, 2016-08-05 23:34:12]

lgtm
Thanks for doing this.

[afakhry, 2016-08-05 23:37:24]

The CQ bit was unchecked by afakhry@chromium.org

[afakhry, 2016-08-05 23:37:29]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-08-05 23:37:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 00:17:19]

Description was changed from

==========
Clean up and modernize the feedback code

BUG=634518
TEST=Tests should keep passing.
==========

to

==========
Clean up and modernize the feedback code

BUG=634518
TEST=Tests should keep passing.
==========

[commit-bot: I haz the power, 2016-08-06 00:17:20]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-06 00:19:50]

Description was changed from

==========
Clean up and modernize the feedback code

BUG=634518
TEST=Tests should keep passing.
==========

to

==========
Clean up and modernize the feedback code

BUG=634518
TEST=Tests should keep passing.

Committed: https://crrev.com/7945509958001242f8d26cf3b6d3d4e5596f52c8
Cr-Commit-Position: refs/heads/master@{#410223}
==========

[commit-bot: I haz the power, 2016-08-06 00:19:51]

Patchset 3 (id:??) landed as
https://crrev.com/7945509958001242f8d26cf3b6d3d4e5596f52c8
Cr-Commit-Position: refs/heads/master@{#410223}