Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2216903003: Revert of [api] Clean up scopes and precheck instantiations cache (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
Reviewers:
Yang, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [api] Clean up scopes and precheck instantiations cache (patchset #3 id:40001 of https://codereview.chromium.org/2206773003/ ) Reason for revert: [Sheriff] Leads to mac asan failures: https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7835 Original issue's description: > [api] Clean up scopes and precheck instantiations cache > > Make sure all the scopes used in api-natives.cc have inlineable constructors > and destructors. Additionally directly precheck the instantiations cache before > trying to enter the InvokeScope which sets the save_context. > > BUG=chromium:630217 > > Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5 > Cr-Commit-Position: refs/heads/master@{#38346} TBR=yangguo@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630217 Committed: https://crrev.com/e1b5cb43a9b90546ff5d6cea89ba17c485e842fb Cr-Commit-Position: refs/heads/master@{#38356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -77 lines) Patch
M src/api-natives.cc View 7 chunks +30 lines, -59 lines 0 comments Download
M src/isolate.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
Created Revert of [api] Clean up scopes and precheck instantiations cache
4 years, 4 months ago (2016-08-05 06:53:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216903003/1
4 years, 4 months ago (2016-08-05 06:53:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 06:54:06 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e1b5cb43a9b90546ff5d6cea89ba17c485e842fb Cr-Commit-Position: refs/heads/master@{#38356}
4 years, 4 months ago (2016-08-05 06:56:41 UTC) #7
Camillo Bruni
4 years, 4 months ago (2016-08-05 20:19:25 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2217353002/ by cbruni@chromium.org.

The reason for reverting is: asan failures are caused by a flaky stack-verflow
(see https://codereview.chromium.org/2218033002 for a fix)..

Powered by Google App Engine
This is Rietveld 408576698