Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2218033002: [cctest] Reducing recursion depth for asan tests. (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cctest] Reducing recursion depth for asan tests. Drive-by-fix: improve threading test log output by also showing the names of the tests when they start and end. Committed: https://crrev.com/9e4a3040080df2dba82c06d4ba498d926f092866 Cr-Commit-Position: refs/heads/master@{#38402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M test/cctest/test-api.cc View 3 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Camillo Bruni
PTAL This test seems to fail randomly for unrelated changes... Don't know if there is ...
4 years, 4 months ago (2016-08-05 12:46:15 UTC) #2
Michael Achenbach
lgtm - also the additional output is intended? please mention it too in the CL ...
4 years, 4 months ago (2016-08-05 12:48:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218033002/1
4 years, 4 months ago (2016-08-05 20:16:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 20:56:14 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 20:59:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e4a3040080df2dba82c06d4ba498d926f092866
Cr-Commit-Position: refs/heads/master@{#38402}

Powered by Google App Engine
This is Rietveld 408576698