S390: Decouple TF Operator kS390_And/Or/Xor/Not to 32/64

S390: Decouple TF Operator kS390_And/Or/Xor/Not to 32/64

Separate 32 and 64 And/Or/Xor/Not Operation

R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com
BUG=

Committed: https://crrev.com/27c56efb39e7c7c2e1753602e647b8cd5ae7e0c3
Cr-Commit-Position: refs/heads/master@{#38397}

[john.yan, 2016-08-05 13:17:50]

PTAL

[JoranSiu, 2016-08-05 13:23:40]

https://codereview.chromium.org/2216883003/diff/1/src/compiler/s390/code-gene...
File src/compiler/s390/code-generator-s390.cc (right):

https://codereview.chromium.org/2216883003/diff/1/src/compiler/s390/code-gene...
src/compiler/s390/code-generator-s390.cc:993: ASSEMBLE_BINOP(AndP);

Instead of using AndP masm routines for the 64-bit op, should we just use the
And64 flavours?  That way you are guaranteed to get the 64-bit instruction.

[john.yan, 2016-08-05 14:26:42]

https://codereview.chromium.org/2216883003/diff/1/src/compiler/s390/code-gene...
File src/compiler/s390/code-generator-s390.cc (right):

https://codereview.chromium.org/2216883003/diff/1/src/compiler/s390/code-gene...
src/compiler/s390/code-generator-s390.cc:993: ASSEMBLE_BINOP(AndP);
On 2016/08/05 13:23:40, JoranSiu wrote:
> 
> Instead of using AndP masm routines for the 64-bit op, should we just use the
> And64 flavours?  That way you are guaranteed to get the 64-bit instruction.

We don't have a And64 for now. And given that And64 won't be generated in 32
bit. So it's save to use AndP here. I want to cleanup this later.

[JaideepBajwa, 2016-08-05 17:58:53]

lgtm

[john.yan, 2016-08-05 17:59:20]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2016-08-05 17:59:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:21:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-05 18:25:14]

Description was changed from

==========
S390: Decouple TF Operator kS390_And/Or/Xor/Not to 32/64

Separate 32 and 64 And/Or/Xor/Not Operation

R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com,
bjaideep@ca.ibm.com
BUG=
==========

to

==========
S390: Decouple TF Operator kS390_And/Or/Xor/Not to 32/64

Separate 32 and 64 And/Or/Xor/Not Operation

R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com,
bjaideep@ca.ibm.com
BUG=

Committed: https://crrev.com/27c56efb39e7c7c2e1753602e647b8cd5ae7e0c3
Cr-Commit-Position: refs/heads/master@{#38397}
==========

[commit-bot: I haz the power, 2016-08-05 18:25:14]

Patchset 1 (id:??) landed as
https://crrev.com/27c56efb39e7c7c2e1753602e647b8cd5ae7e0c3
Cr-Commit-Position: refs/heads/master@{#38397}