chrome/browser/history/android/android_history_provider_service_unittest.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/android_history_provider_service_unittest.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/favicon/favicon_utils.cc ('k') | chrome/browser/history/android/android_provider_backend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/android/android_history_provider_service_unittest.cc

diff --git a/chrome/browser/history/android/android_history_provider_service_unittest.cc b/chrome/browser/history/android/android_history_provider_service_unittest.cc

index c03ec1351ed0f5f082b3a4fb51ee2ac9c47ee046..827d24bcc6e121d1ec4c171082a453d73ac0b48b 100644

--- a/chrome/browser/history/android/android_history_provider_service_unittest.cc

+++ b/chrome/browser/history/android/android_history_provider_service_unittest.cc

@@ -58,7 +58,7 @@ class AndroidHistoryProviderServiceTest : public testing::Test {

testing_profile_->CreateBookmarkModel(true);

bookmarks::test::WaitForBookmarkModelToLoad(

- BookmarkModelFactory::GetForProfile(testing_profile_));

+ BookmarkModelFactory::GetForBrowserContext(testing_profile_));

ASSERT_TRUE(testing_profile_->CreateHistoryService(true, false));

service_.reset(new AndroidHistoryProviderService(testing_profile_));

}

@@ -66,7 +66,7 @@ class AndroidHistoryProviderServiceTest : public testing::Test {

void TearDown() override {

testing_profile_->DestroyHistoryService();

profile_manager_.DeleteTestingProfile(chrome::kInitialProfile);

- testing_profile_=NULL;

+ testing_profile_ = NULL;

sky 2016/08/04 20:09:13 If you're going to change this you may as well upd

Philipp Keck 2016/08/05 07:57:17 Done.

}

protected:

« no previous file with comments | « chrome/browser/favicon/favicon_utils.cc ('k') | chrome/browser/history/android/android_provider_backend_unittest.cc » ('j') | no next file with comments »