chrome/browser/favicon/favicon_utils.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_utils.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/history/android/android_history_provider_service_unittest.cc » ('j') | chrome/browser/history/android/android_history_provider_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/favicon/favicon_utils.cc

diff --git a/chrome/browser/favicon/favicon_utils.cc b/chrome/browser/favicon/favicon_utils.cc

index fc8cd058cf3337591473ac9835ea59ec9eb521e6..a662aeb28f226ad69a0284474c9dd97b8d498e71 100644

--- a/chrome/browser/favicon/favicon_utils.cc

+++ b/chrome/browser/favicon/favicon_utils.cc

@@ -28,7 +28,7 @@ void CreateContentFaviconDriverForWebContents(

original_profile, ServiceAccessType::IMPLICIT_ACCESS),

HistoryServiceFactory::GetForProfile(original_profile,

ServiceAccessType::IMPLICIT_ACCESS),

- BookmarkModelFactory::GetForProfileIfExists(original_profile));

+ BookmarkModelFactory::GetForBrowserContextIfExists(original_profile));

}

bool ShouldDisplayFavicon(content::WebContents* web_contents) {