chrome/browser/extensions/lazy_background_page_apitest.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker_unittest.cc ('k') | chrome/browser/favicon/favicon_utils.cc » ('j') | chrome/browser/history/android/android_history_provider_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/lazy_background_page_apitest.cc

diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc

index 26383374e779dd982c2714933f28ec0bd096f83f..22f04e094ea0c8bdb163aac9d72fc7c7c217b6a6 100644

--- a/chrome/browser/extensions/lazy_background_page_apitest.cc

+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc

@@ -464,7 +464,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, DISABLED_IncognitoSplitMode) {

LazyBackgroundObserver page_complete(browser()->profile()),

page2_complete(incognito_browser->profile());

BookmarkModel* bookmark_model =

- BookmarkModelFactory::GetForProfile(browser()->profile());

+ BookmarkModelFactory::GetForBrowserContext(browser()->profile());

bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);

const BookmarkNode* parent = bookmark_model->bookmark_bar_node();

bookmark_model->AddURL(

@@ -580,7 +580,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, EventDispatchToTab) {

// Send an event by making a bookmark.

BookmarkModel* bookmark_model =

- BookmarkModelFactory::GetForProfile(browser()->profile());

+ BookmarkModelFactory::GetForBrowserContext(browser()->profile());

bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);

bookmarks::AddIfNotBookmarked(bookmark_model,

GURL("http://www.google.com"),