Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: chrome/browser/bookmarks/bookmark_model_factory.h

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks
Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_model_factory.h
diff --git a/chrome/browser/bookmarks/bookmark_model_factory.h b/chrome/browser/bookmarks/bookmark_model_factory.h
index 25448e70c429cb3d8001b366321b4c38b3bd804f..9fbce96c3d5cc7f0e3625faafcaa47496ab66fc7 100644
--- a/chrome/browser/bookmarks/bookmark_model_factory.h
+++ b/chrome/browser/bookmarks/bookmark_model_factory.h
@@ -12,13 +12,12 @@ namespace base {
template <typename T> struct DefaultSingletonTraits;
}
-class Profile;
-
namespace bookmarks {
class BookmarkModel;
}
-// Singleton that owns all BookmarkModels and associates them with Profiles.
+// Singleton that owns all BookmarkModels and associates them with
+// BrowserContexts.
class BookmarkModelFactory : public BrowserContextKeyedServiceFactory {
public:
static bookmarks::BookmarkModel* GetForBrowserContext(
@@ -27,12 +26,6 @@ class BookmarkModelFactory : public BrowserContextKeyedServiceFactory {
static bookmarks::BookmarkModel* GetForBrowserContextIfExists(
content::BrowserContext* browser_context);
- // TODO(pke): Remove GetForProfile and GetForProfileIfExists and use
- // GetForBrowserContext/GetForBrowserContextIfExists everywhere.
- static bookmarks::BookmarkModel* GetForProfile(Profile* profile);
-
- static bookmarks::BookmarkModel* GetForProfileIfExists(Profile* profile);
-
static BookmarkModelFactory* GetInstance();
private:

Powered by Google App Engine
This is Rietveld 408576698