chrome/browser/android/provider/chrome_browser_provider.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/provider/chrome_browser_provider.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/omnibox/autocomplete_controller_android.cc ('k') | chrome/browser/android/signin/signin_manager_android.cc » ('j') | chrome/browser/history/android/android_history_provider_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/provider/chrome_browser_provider.cc

diff --git a/chrome/browser/android/provider/chrome_browser_provider.cc b/chrome/browser/android/provider/chrome_browser_provider.cc

index 32746fbcabe0d40d6a3e3d740c05da7db6651c09..f9db56038ef109291e81b7d9ef019d6ceb258703 100644

--- a/chrome/browser/android/provider/chrome_browser_provider.cc

+++ b/chrome/browser/android/provider/chrome_browser_provider.cc

@@ -824,7 +824,7 @@ ChromeBrowserProvider::ChromeBrowserProvider(JNIEnv* env, jobject obj)

handling_extensive_changes_(false) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

profile_ = g_browser_process->profile_manager()->GetLastUsedProfile();

- bookmark_model_ = BookmarkModelFactory::GetForProfile(profile_);

+ bookmark_model_ = BookmarkModelFactory::GetForBrowserContext(profile_);

top_sites_ = TopSitesFactory::GetForProfile(profile_);

favicon_service_ = FaviconServiceFactory::GetForProfile(

profile_, ServiceAccessType::EXPLICIT_ACCESS),