chrome/browser/android/omnibox/autocomplete_controller_android.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/omnibox/autocomplete_controller_android.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/history_report/history_report_jni_bridge.cc ('k') | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | chrome/browser/history/android/android_history_provider_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/omnibox/autocomplete_controller_android.cc

diff --git a/chrome/browser/android/omnibox/autocomplete_controller_android.cc b/chrome/browser/android/omnibox/autocomplete_controller_android.cc

index 5eb606bfbabb0885888f41fdcda87b4f6475b263..8a785037960ef6456ebf7831a555e610466f65d0 100644

--- a/chrome/browser/android/omnibox/autocomplete_controller_android.cc

+++ b/chrome/browser/android/omnibox/autocomplete_controller_android.cc

@@ -529,7 +529,8 @@ AutocompleteControllerAndroid::BuildOmniboxSuggestion(

ConvertUTF16ToJavaString(env, match.fill_into_edit);

ScopedJavaLocalRef<jstring> destination_url =

ConvertUTF8ToJavaString(env, match.destination_url.spec());

- BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(profile_);

+ BookmarkModel* bookmark_model =

+ BookmarkModelFactory::GetForBrowserContext(profile_);

return Java_AutocompleteController_buildOmniboxSuggestion(

env,

match.type,