chrome/browser/ui/webui/options/certificate_manager_handler.cc - Issue 22165002: Change the meaning of SelectFileDialog.support_drive: it means Drive-aware callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/certificate_manager_handler.cc

Issue 22165002: Change the meaning of SelectFileDialog.support_drive: it means Drive-aware callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fix (#2). Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/certificate_dialogs.cc ('k') | chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/certificate_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc

index f77cc8b3200c597e4038a7e50c485958a3c4f7fe..3ad62db88a6127f3e160484ab31632e297126444 100644

--- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc

@@ -624,8 +624,6 @@ void CertificateManagerHandler::ExportPersonal(const ListValue* args) {

file_type_info.extension_description_overrides.push_back(

l10n_util::GetStringUTF16(IDS_CERT_MANAGER_PKCS12_FILES));

file_type_info.include_all_files = true;

- // TODO(kinaba): http://crbug.com/140425. Turn file_type_info.support_drive

- // on once Google Drive client on ChromeOS fully supports file writing.

select_file_dialog_ = ui::SelectFileDialog::Create(

this, new ChromeSelectFilePolicy(web_ui()->GetWebContents()));

select_file_dialog_->SelectFile(

@@ -716,7 +714,6 @@ void CertificateManagerHandler::StartImportPersonal(const ListValue* args) {