chrome/browser/ui/certificate_dialogs.cc - Issue 22165002: Change the meaning of SelectFileDialog.support_drive: it means Drive-aware callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/certificate_dialogs.cc

Issue 22165002: Change the meaning of SelectFileDialog.support_drive: it means Drive-aware callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fix (#2). Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/file_manager/js/file_manager.js ('k') | chrome/browser/ui/webui/options/certificate_manager_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/certificate_dialogs.cc

diff --git a/chrome/browser/ui/certificate_dialogs.cc b/chrome/browser/ui/certificate_dialogs.cc

index 939c3a13a7ee7b0f60c947dfb8cbc602f3208d0d..fbc0825e2e4c19761352620eab5792447ab59952 100644

--- a/chrome/browser/ui/certificate_dialogs.cc

+++ b/chrome/browser/ui/certificate_dialogs.cc

@@ -170,13 +170,10 @@ void ShowCertSelectFileDialog(ui::SelectFileDialog* select_file_dialog,

file_type_info.extension_description_overrides.push_back(

l10n_util::GetStringUTF16(IDS_CERT_EXPORT_TYPE_PKCS7_CHAIN));

file_type_info.include_all_files = true;

- // TODO(kinaba): http://crbug.com/140425. Turn file_type_info.support_drive

- // on for saving once Google Drive client on ChromeOS supports it.

- if (type == ui::SelectFileDialog::SELECT_OPEN_FILE)

- file_type_info.support_drive = true;

select_file_dialog->SelectFile(

type, string16(),

- suggested_path, &file_type_info, 1,

+ suggested_path, &file_type_info,

+ 1, // 1-based index for |file_type_info.extensions| to specify default.

FILE_PATH_LITERAL("crt"),

parent, params);

}