Issue 2216083003: Reland "Remove redundant ParseInfo::scope_."

Issue 2216083003: Reland "Remove redundant ParseInfo::scope_." (Closed)

Created:
4 years, 4 months ago by neis

Modified:
4 years, 4 months ago

Reviewers:
adamk

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Reland "Remove redundant ParseInfo::scope_." Original commit message: > Remove redundant ParseInfo::scope_. > > This was always set to the literal's scope. > > (Additional change: mark getters as const.) > > R=adamk@chromium.org > BUG= > > Review-Url: https://codereview.chromium.org/2216563003 > Cr-Commit-Position: refs/heads/master@{#38372} > This was always set to the literal's scope. TBR=adamk@chromium.org BUG= Committed: https://crrev.com/3651bff016fc7f305631cc8405800f17e8d51480 Cr-Commit-Position: refs/heads/master@{#38393}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -28 lines)			Patch
M	src/ast/scopes.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/compiler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/parsing/parser.h	View	8 chunks	+25 lines, -23 lines	0 comments	Download
M	src/parsing/parser.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216083003/1

4 years, 4 months ago (2016-08-05 15:36:36 UTC) #2

commit-bot: I haz the power

4 years, 4 months ago (2016-08-05 16:06:04 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3651bff016fc7f305631cc8405800f17e8d51480
Cr-Commit-Position: refs/heads/master@{#38393}