Rename the app banner variations key for total site engagement score.

chrome/browser/banners/app_banner_settings_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 60 matching lines @@
 // Keys to use when storing BannerEvent structs.
 const char kBannerTimeKey[] = "time";
 const char kBannerEngagementKey[] = "engagement";
 
 // Keys to use when querying the variations params.
 const char kBannerParamsKey[] = "AppBannerTriggering";
 const char kBannerParamsDirectKey[] = "direct";
 const char kBannerParamsIndirectKey[] = "indirect";
 const char kBannerParamsTotalKey[] = "total";
 const char kBannerParamsMinutesKey[] = "minutes";
+const char kBannerParamsEngagementTotalKey[] = "site_engagement_total";
 const char kBannerSiteEngagementParamsKey[] = "use_site_engagement";
 
 // Engagement weight assigned to direct and indirect navigations.
 // By default, a direct navigation is a page visit via ui::PAGE_TRANSITION_TYPED
 // or ui::PAGE_TRANSITION_GENERATED.
 double gDirectNavigationEngagement = kDefaultDirectNavigationEngagement;
 double gIndirectNavigationEnagagement = kDefaultIndirectNavigationEngagement;
 
 // Number of minutes between visits that will trigger a could show banner event.
 // Defaults to the number of minutes in a day.
@@ skipping 41 matching lines @@
     return gDirectNavigationEngagement;
   } else {
     return gIndirectNavigationEnagagement;
   }
 }
 
 // Queries variations for the maximum site engagement score required to trigger
 // the banner showing.
 void UpdateSiteEngagementToTrigger() {
   std::string total_param = variations::GetVariationParamValue(
-      kBannerParamsKey, kBannerParamsTotalKey);
+      kBannerParamsKey, kBannerParamsEngagementTotalKey);
 
   if (!total_param.empty()) {
     double total_engagement = -1;
 
     if (base::StringToDouble(total_param, &total_engagement) &&
         total_engagement > 0) {
       AppBannerSettingsHelper::SetTotalEngagementToTrigger(total_engagement);
     }
   }
 }
@@ skipping 494 matching lines @@
     return true;
   }
 
   // Assume any value which is not "0" or "false" indicates that we should use
   // site engagement.
   std::string param = variations::GetVariationParamValue(
       kBannerParamsKey, kBannerSiteEngagementParamsKey);
 
   return (!param.empty() && param != "0" && param != "false");
 }