Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: net/spdy/spdy_framer.cc

Issue 22159003: DO NOT COMMIT: More hacks to get HTTP/2 working Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update for draft 06 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/spdy_http_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_framer.cc
diff --git a/net/spdy/spdy_framer.cc b/net/spdy/spdy_framer.cc
index c99c2f83895a96ebd021295d97c783edb4ec682b..d88190ef7c0d2dcbf9b4d411328770deded42304 100644
--- a/net/spdy/spdy_framer.cc
+++ b/net/spdy/spdy_framer.cc
@@ -734,7 +734,8 @@ void SpdyFramer::ProcessControlFrameHeader(uint16 control_frame_type_field) {
break;
case PING:
if (current_frame_length_ != GetPingSize()) {
- set_error(SPDY_INVALID_CONTROL_FRAME);
+ // TODO(akalin): Unignore this.
+ // set_error(SPDY_INVALID_CONTROL_FRAME);
} else if (spdy_version_ < SPDY4 && current_frame_flags_ != 0) {
set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
} else if (spdy_version_ >= SPDY4 && (current_frame_flags_ & ~0x1) != 0) {
@@ -773,7 +774,8 @@ void SpdyFramer::ProcessControlFrameHeader(uint16 control_frame_type_field) {
if (current_frame_length_ != GetWindowUpdateSize()) {
set_error(SPDY_INVALID_CONTROL_FRAME);
} else if (current_frame_flags_ != 0) {
- set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
+ // TODO(akalin): Implement END_FLOW_CONTROL handling.
+ // set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
}
break;
case CREDENTIAL:
@@ -1401,6 +1403,9 @@ bool SpdyFramer::ProcessSetting(const char* data) {
case SETTINGS_INITIAL_WINDOW_SIZE:
// Valid values.
break;
+ case SETTINGS_FLOW_CONTROL_OPTIONS:
+ // TODO(akalin): Implement this.
+ break;
default:
DLOG(WARNING) << "Unknown SETTINGS ID: " << id_and_flags.id();
return false;
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/spdy_http_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698