DO NOT COMMIT: More hacks to get HTTP/2 working

net/spdy/spdy_framer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(rtenhove) clean up frame buffer size calculations so that we aren't
 // constantly adding and subtracting header sizes; this is ugly and error-
 // prone.
 
 #include "net/spdy/spdy_framer.h"
 
@@ skipping 716 matching lines @@
         DLOG(WARNING) << "Invalid length for SETTINGS frame: "
                       << current_frame_length_;
         set_error(SPDY_INVALID_CONTROL_FRAME);
       } else if (current_frame_flags_ &
                  ~SETTINGS_FLAG_CLEAR_PREVIOUSLY_PERSISTED_SETTINGS) {
         set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
       }
       break;
     case PING:
       if (current_frame_length_ != GetPingSize()) {
-        set_error(SPDY_INVALID_CONTROL_FRAME);
+        // TODO(akalin): Unignore this.
+        // set_error(SPDY_INVALID_CONTROL_FRAME);
       } else if (spdy_version_ < SPDY4 && current_frame_flags_ != 0) {
         set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
       } else if (spdy_version_ >= SPDY4 && (current_frame_flags_ & ~0x1) != 0) {
         // TODO(akalin): Unignore this.
         // set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
       }
       break;
     case GOAWAY:
       {
         if (current_frame_length_ != GetGoAwaySize()) {
@@ skipping 18 matching lines @@
                    ~(CONTROL_FLAG_FIN | HEADERS_FLAG_PRIORITY |
                      HEADERS_FLAG_END_HEADERS)) {
           set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
         }
       }
       break;
     case WINDOW_UPDATE:
       if (current_frame_length_ != GetWindowUpdateSize()) {
         set_error(SPDY_INVALID_CONTROL_FRAME);
       } else if (current_frame_flags_ != 0) {
-        set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
+        // TODO(akalin): Implement END_FLOW_CONTROL handling.
+        // set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
       }
       break;
     case CREDENTIAL:
       if (current_frame_length_ < GetCredentialMinimumSize()) {
         set_error(SPDY_INVALID_CONTROL_FRAME);
       } else if (current_frame_flags_ != 0) {
         set_error(SPDY_INVALID_CONTROL_FRAME_FLAGS);
       }
       break;
     case BLOCKED:
@@ skipping 607 matching lines @@
   switch (id_and_flags.id()) {
     case SETTINGS_UPLOAD_BANDWIDTH:
     case SETTINGS_DOWNLOAD_BANDWIDTH:
     case SETTINGS_ROUND_TRIP_TIME:
     case SETTINGS_MAX_CONCURRENT_STREAMS:
     case SETTINGS_CURRENT_CWND:
     case SETTINGS_DOWNLOAD_RETRANS_RATE:
     case SETTINGS_INITIAL_WINDOW_SIZE:
       // Valid values.
       break;
+    case SETTINGS_FLOW_CONTROL_OPTIONS:
+      // TODO(akalin): Implement this.
+      break;
     default:
       DLOG(WARNING) << "Unknown SETTINGS ID: " << id_and_flags.id();
       return false;
   }
   SpdySettingsIds id = static_cast<SpdySettingsIds>(id_and_flags.id());
 
   // Detect duplciates.
   if (static_cast<uint32>(id) <= settings_scratch_.last_setting_id) {
     DLOG(WARNING) << "Duplicate entry or invalid ordering for id " << id
                   << " in " << display_protocol_ << " SETTINGS frame "
@@ skipping 1074 matching lines @@
   builder->Seek(compressed_size);
   builder->RewriteLength(*this);
 
   pre_compress_bytes.Add(uncompressed_len);
   post_compress_bytes.Add(compressed_size);
 
   compressed_frames.Increment();
 }
 
 }  // namespace net