Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2215873002: fix #26512, correct handling of fuzzy arrows in strong mode LUB (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #26512, correct handling of fuzzy arrows in strong mode LUB R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/9599cd6f502eec70601045270732f90e4a0bea47

Patch Set 1 #

Patch Set 2 : fix glb too #

Patch Set 3 : format #

Patch Set 4 : rebase & fix pass through of arg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -36 lines) Patch
M pkg/analyzer/lib/src/generated/type_system.dart View 1 2 3 10 chunks +32 lines, -34 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 1 3 chunks +14 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-04 16:56:53 UTC) #2
Leaf
lgtm
4 years, 4 months ago (2016-08-04 22:39:50 UTC) #3
Jennifer Messerly
4 years, 4 months ago (2016-08-04 22:47:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
9599cd6f502eec70601045270732f90e4a0bea47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698