Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: pkg/analyzer/test/generated/type_system_test.dart

Issue 2215873002: fix #26512, correct handling of fuzzy arrows in strong mode LUB (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rebase & fix pass through of arg Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/type_system_test.dart
diff --git a/pkg/analyzer/test/generated/type_system_test.dart b/pkg/analyzer/test/generated/type_system_test.dart
index d82d13572d656c025ed7b187c3e685028ee6a650..c62f985f03312e563d3f03f4ee5f1bcc88c66f57 100644
--- a/pkg/analyzer/test/generated/type_system_test.dart
+++ b/pkg/analyzer/test/generated/type_system_test.dart
@@ -164,7 +164,6 @@ class LeastUpperBoundTest extends LeastUpperBoundTestBase {
FunctionType expected = _functionType([objectType, numType, numType]);
_checkLeastUpperBound(type1, type2, expected);
}
-
void test_nestedNestedFunctionsLubInnermostParamTypes() {
FunctionType type1 = _functionType([
_functionType([
@@ -1142,6 +1141,13 @@ class StrongGreatestLowerBoundTest extends BoundTestBase {
_checkGreatestLowerBound(type1, type2, expected);
}
+ void test_functionsFuzzyArrows() {
+ FunctionType type1 = _functionType([dynamicType]);
+ FunctionType type2 = _functionType([intType]);
+ FunctionType expected = _functionType([intType]);
+ _checkGreatestLowerBound(type1, type2, expected);
+ }
+
void test_functionsGlbReturnType() {
FunctionType type1 = _functionType([], returns: intType);
FunctionType type2 = _functionType([], returns: numType);
@@ -1311,6 +1317,13 @@ class StrongLeastUpperBoundTest extends LeastUpperBoundTestBase {
super.setUp();
}
+ void test_functionsFuzzyArrows() {
+ FunctionType type1 = _functionType([dynamicType]);
+ FunctionType type2 = _functionType([intType]);
+ FunctionType expected = _functionType([dynamicType]);
+ _checkLeastUpperBound(type1, type2, expected);
+ }
+
void test_functionsGlbNamedParams() {
FunctionType type1 =
_functionType([], named: {'a': stringType, 'b': intType});
« no previous file with comments | « pkg/analyzer/lib/src/generated/type_system.dart ('k') | pkg/analyzer/test/src/task/strong/checker_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698