Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2215863002: Fix cronet build after JNI registration change. (Closed)

Created:
4 years, 4 months ago by Torne
Modified:
4 years, 4 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix cronet build after JNI registration change. Cronet isn't covered by the CQ and broke when we removed RegisterNativesImpl for classes that don't need it. Fix up by removing the corresponding parts for use_platform_icu_alternatives=true which is only used by cronet. BUG=603936 Committed: https://crrev.com/d8b7d9253622fca97b6fe5cc36c56382b30156fa Cr-Commit-Position: refs/heads/master@{#409867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -126 lines) Patch
M components/cronet/android/cronet_library_loader.cc View 2 chunks +1 line, -6 lines 0 comments Download
M net/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M net/android/net_jni_registrar.cc View 2 chunks +0 lines, -7 lines 0 comments Download
D net/base/net_string_util_icu_alternatives_android.h View 1 chunk +0 lines, -18 lines 0 comments Download
M net/base/net_string_util_icu_alternatives_android.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/run_all_unittests.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M url/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
D url/android/url_jni_registrar.h View 1 chunk +0 lines, -21 lines 0 comments Download
D url/android/url_jni_registrar.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M url/url.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D url/url_canon_icu_alternatives_android.h View 1 chunk +0 lines, -18 lines 0 comments Download
M url/url_canon_icu_alternatives_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M url/url_srcs.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (6 generated)
Torne
+mkwst for url OWNERS +mef for net and cronet OWNERS Sorry we broke this; is ...
4 years, 4 months ago (2016-08-04 16:04:10 UTC) #2
Torne
actually +mef, whoops
4 years, 4 months ago (2016-08-04 16:04:41 UTC) #5
mikecase (-- gone --)
On 2016/08/04 at 16:04:10, torne wrote: > +mkwst for url OWNERS > +mef for net ...
4 years, 4 months ago (2016-08-04 16:05:38 UTC) #6
mef
lgtm
4 years, 4 months ago (2016-08-04 16:08:30 UTC) #7
no sievers
lgtm, thanks!
4 years, 4 months ago (2016-08-04 17:21:09 UTC) #8
Mike West
//url LGTM.
4 years, 4 months ago (2016-08-04 17:28:00 UTC) #9
mikecase (-- gone --)
lgtm
4 years, 4 months ago (2016-08-04 18:13:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215863002/1
4 years, 4 months ago (2016-08-04 18:14:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 19:42:02 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:44:12 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8b7d9253622fca97b6fe5cc36c56382b30156fa
Cr-Commit-Position: refs/heads/master@{#409867}

Powered by Google App Engine
This is Rietveld 408576698