Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002

Committed: https://skia.googlesource.com/skia/+/538d5b68e8b6a8745ac8947f15abf1c7c6de8f18

[borenet2, 2016-08-04 14:28:50]

Description was changed from

==========
Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

BUG=skia:5578
==========

to

==========
Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002
==========

[borenet, 2016-08-04 14:33:16]

Description was changed from

==========
Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002
==========

to

==========
Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002
==========

[borenet, 2016-08-04 14:52:26]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@chromium.org

[borenet, 2016-08-04 17:05:17]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 17:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmistry, 2016-08-04 17:15:45]

rmistry@google.com changed reviewers:
+ rmistry@google.com

[rmistry, 2016-08-04 17:15:47]

lgtm

https://codereview.chromium.org/2215803002/diff/20001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/builder_name_schema/api.py (right):

https://codereview.chromium.org/2215803002/diff/20001/infra/bots/recipe_modul...
infra/bots/recipe_modules/builder_name_schema/api.py:30: self.TRYBOT_NAME_SUFFIX
= builder_name_schema.TRYBOT_NAME_SUFFIX
Not sure these variables need to be in CAPS but if it helped minimize diffs then
go ahead and leave as is.

https://codereview.chromium.org/2215803002/diff/20001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/vars/api.py (right):

https://codereview.chromium.org/2215803002/diff/20001/infra/bots/recipe_modul...
infra/bots/recipe_modules/vars/api.py:19: def gyp_defines(builder_dict):
Should this be get_gyp_defines? gyp_defines makes it sound like a property. Most
other functions here follow this format (device_cfg/product_board).
Maybe we should just change the ones that are different instead Eg:
get_extra_env_vars -> extra_env_vars

[commit-bot: I haz the power, 2016-08-04 17:17:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 17:17:25]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[borenet, 2016-08-04 17:23:41]

https://codereview.chromium.org/2215803002/diff/20001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/builder_name_schema/api.py (right):

https://codereview.chromium.org/2215803002/diff/20001/infra/bots/recipe_modul...
infra/bots/recipe_modules/builder_name_schema/api.py:30: self.TRYBOT_NAME_SUFFIX
= builder_name_schema.TRYBOT_NAME_SUFFIX
On 2016/08/04 17:15:46, rmistry wrote:
> Not sure these variables need to be in CAPS but if it helped minimize diffs
then
> go ahead and leave as is.

I just wanted everything to be pretty much the same.  They're "constants" in
builder_name_schema.py so it makes sense there, and since they can't be accessed
that way through recipes depending on this module, IMO it makes sense to have
them in CAPS here.

https://codereview.chromium.org/2215803002/diff/20001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/vars/api.py (right):

https://codereview.chromium.org/2215803002/diff/20001/infra/bots/recipe_modul...
infra/bots/recipe_modules/vars/api.py:19: def gyp_defines(builder_dict):
On 2016/08/04 17:15:46, rmistry wrote:
> Should this be get_gyp_defines? gyp_defines makes it sound like a property.
Most
> other functions here follow this format (device_cfg/product_board).
> Maybe we should just change the ones that are different instead Eg:
> get_extra_env_vars -> extra_env_vars

I just copied what was in buildbot_spec.py, but yeah, changed to
get_gyp_defines.

[borenet, 2016-08-04 17:24:03]

The CQ bit was checked by borenet@google.com

[borenet, 2016-08-04 17:24:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2215803002/#ps40001
(title: "gyp_defines -> get_gyp_defines")

[commit-bot: I haz the power, 2016-08-04 17:24:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 17:33:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 17:33:51]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[borenet, 2016-08-04 17:48:53]

The CQ bit was checked by borenet@google.com

[borenet, 2016-08-04 17:48:54]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2215803002/#ps60001
(title: "Add missing blacklist")

[commit-bot: I haz the power, 2016-08-04 17:48:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 18:07:13]

Description was changed from

==========
Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002
==========

to

==========
Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002

Committed:
https://skia.googlesource.com/skia/+/538d5b68e8b6a8745ac8947f15abf1c7c6de8f18
==========

[commit-bot: I haz the power, 2016-08-04 18:07:14]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/538d5b68e8b6a8745ac8947f15abf1c7c6de8f18