Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2215783002: [perf] Disable memory.blink_memory_mobile.reference on Nexus 5X (Closed)

Created:
4 years, 4 months ago by petrcermak
Modified:
4 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[perf] Disable memory.blink_memory_mobile.reference on Nexus 5X Rationale: The benchmark is very flaky on Nexus 5X (6 failures in the last 20 runs). BUG=634319 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq TBR=skyostil Committed: https://crrev.com/3a4f654ac5c0ddd30f9194531add5b108f43d1dd Cr-Commit-Position: refs/heads/master@{#409789}

Patch Set 1 #

Patch Set 2 : Disable only on Nexus 5X #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 4 months ago (2016-08-04 13:54:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215783002/20001
4 years, 4 months ago (2016-08-04 13:55:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 15:27:15 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3a4f654ac5c0ddd30f9194531add5b108f43d1dd Cr-Commit-Position: refs/heads/master@{#409789}
4 years, 4 months ago (2016-08-04 15:28:54 UTC) #11
Sami
4 years, 4 months ago (2016-08-04 15:34:06 UTC) #12
Message was sent while issue was closed. 
lgtm.

Powered by Google App Engine
This is Rietveld 408576698