Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tools/perf/benchmarks/memory_infra.py

Issue 2215783002: [perf] Disable memory.blink_memory_mobile.reference on Nexus 5X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable only on Nexus 5X Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 8
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import chrome_trace_category_filter 10 from telemetry.timeline import chrome_trace_category_filter
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 158
159 @classmethod 159 @classmethod
160 def Name(cls): 160 def Name(cls):
161 return 'memory.blink_memory_mobile' 161 return 'memory.blink_memory_mobile'
162 162
163 @classmethod 163 @classmethod
164 def ValueCanBeAddedPredicate(cls, value, is_first_result): 164 def ValueCanBeAddedPredicate(cls, value, is_first_result):
165 return (not _IGNORED_STATS_RE.search(value.name) and 165 return (not _IGNORED_STATS_RE.search(value.name) and
166 'renderer_processes' in value.name) 166 'renderer_processes' in value.name)
167 167
168 @classmethod
169 def ShouldDisable(cls, possible_browser):
170 # http://crbug.com/634319
171 return (possible_browser.browser_type == 'reference' and
172 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
173
168 174
169 class _MemoryV8Benchmark(_MemoryInfra): 175 class _MemoryV8Benchmark(_MemoryInfra):
170 176
171 # Report only V8-specific and overall renderer memory values. Note that 177 # Report only V8-specific and overall renderer memory values. Note that
172 # detailed values reported by the OS (such as native heap) are excluded. 178 # detailed values reported by the OS (such as native heap) are excluded.
173 _V8_AND_OVERALL_MEMORY_RE = re.compile( 179 _V8_AND_OVERALL_MEMORY_RE = re.compile(
174 r'renderer_processes:' 180 r'renderer_processes:'
175 r'(reported_by_chrome:v8|reported_by_os:system_memory:[^:]+$)') 181 r'(reported_by_chrome:v8|reported_by_os:system_memory:[^:]+$)')
176 182
177 def CreateTimelineBasedMeasurementOptions(self): 183 def CreateTimelineBasedMeasurementOptions(self):
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 of long running idle Gmail page """ 222 of long running idle Gmail page """
217 page_set = page_sets.LongRunningIdleGmailBackgroundPageSet 223 page_set = page_sets.LongRunningIdleGmailBackgroundPageSet
218 224
219 @classmethod 225 @classmethod
220 def Name(cls): 226 def Name(cls):
221 return 'memory.long_running_idle_gmail_background_tbmv2' 227 return 'memory.long_running_idle_gmail_background_tbmv2'
222 228
223 @classmethod 229 @classmethod
224 def ShouldDisable(cls, possible_browser): # http://crbug.com/616530 230 def ShouldDisable(cls, possible_browser): # http://crbug.com/616530
225 return cls.IsSvelte(possible_browser) 231 return cls.IsSvelte(possible_browser)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698